Refactor build structure and add noble.#126
Conversation
build_image
Outdated
|
|
||
| function bootstrap_docker() | ||
| { | ||
| usdo apt-get update --quiet --quiet |
There was a problem hiding this comment.
- usdo > sudo
- Do we need --quiet twice?
There was a problem hiding this comment.
Good catch. I don't know about the double quiet, it was a copy paste from an existing command. I'm fine setting to a single quiet, it's a convenience function to install docker.
| cd st2packaging-dockerfiles/packagingbuild/focal | ||
| docker build -t stackstorm/packagingbuild:focal . | ||
| # ./build_image | ||
| Usage ./build_image <bootstrap|build [distro]> |
There was a problem hiding this comment.
probably worth mentioning what OS this build_image works on, as it looks to be deb only, I couldn't run this on my mac
There was a problem hiding this comment.
The ./build_image build jammy command should work on any *nix distro that has docker installed.
There was a problem hiding this comment.
I've added a note about bootstrap only supporting Ubuntu.
skiedude
left a comment
skiedude
left a comment
There was a problem hiding this comment.
Looks good, once this is merged I can add the rocky10 packages
3 participants
This PR is quite large, so it'll be easier to understand what has changed by reviewing commit by commit.